Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GodotCollisionSolver2D::solve_concave: Fix culling in case of motion #88282

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

rburing
Copy link
Member

@rburing rburing commented Feb 13, 2024

From debugging it was clear that concave_callback was not getting called, so local_aabb was too small, so I expanded it in the motion direction, which fixed the issues.

@rburing rburing added this to the 4.3 milestone Feb 13, 2024
@rburing rburing requested a review from a team as a code owner February 13, 2024 13:59
@akien-mga akien-mga changed the title GodotCollisionSolver2D::solve_concave: fix culling in case of motion GodotCollisionSolver2D::solve_concave: Fix culling in case of motion Feb 13, 2024
@akien-mga akien-mga merged commit e0c24eb into godotengine:master Feb 13, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@rburing rburing deleted the concave_motion_2d branch February 13, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants