-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Skeleton3D insert key tooltips #88386
Conversation
Does the button only key rotations, or also translations? If it's only rotations, that button was even more severely mislabeled than I originally thought |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect something is wrong.
I think this refers to keyframes of loc,rot, and scale. Where does it say rotation only?
@fire both buttons only work for rotation, I tested that before making this PR. If they're intended to keyframe position and scale as well that's currently broken in 4.2.1. Here's a video of me using the buttons. |
You were right Fire, I completely forgot about those buttons. I've updated this PR but I'd like to re-word it further tomorrow. I want to try and keep the description consistent with what we use for the key button in the toolbar for 2D scenes. |
Updated description again, ready for review again. |
Needs rebase. Edit: Rebased myself. |
Thanks! |
Original text looks like it was written by someone in the middle of a stroke. This PR fixes that. Closes godotengine/godot-docs#8957