Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Skeleton3D insert key tooltips #88386

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Conversation

skyace65
Copy link
Contributor

@skyace65 skyace65 commented Feb 16, 2024

Original text looks like it was written by someone in the middle of a stroke. This PR fixes that. Closes godotengine/godot-docs#8957

@skyace65 skyace65 requested a review from a team as a code owner February 16, 2024 02:47
@skyace65 skyace65 changed the title Fix Skeleton 3D insert key tooltip Fix Skeleton3D insert key tooltips Feb 16, 2024
@YeldhamDev YeldhamDev added this to the 4.3 milestone Feb 16, 2024
@hunterbk
Copy link

Does the button only key rotations, or also translations? If it's only rotations, that button was even more severely mislabeled than I originally thought

fire
fire previously requested changes Feb 16, 2024
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect something is wrong.

I think this refers to keyframes of loc,rot, and scale. Where does it say rotation only?

editor/plugins/skeleton_3d_editor_plugin.cpp Outdated Show resolved Hide resolved
@skyace65
Copy link
Contributor Author

@fire both buttons only work for rotation, I tested that before making this PR. If they're intended to keyframe position and scale as well that's currently broken in 4.2.1. Here's a video of me using the buttons.
Button Test.zip

@fire
Copy link
Member

fire commented Feb 16, 2024

In your video the button for rotation was selected, did you try selecting the other buttons (next to it).

image

@skyace65
Copy link
Contributor Author

You were right Fire, I completely forgot about those buttons. I've updated this PR but I'd like to re-word it further tomorrow. I want to try and keep the description consistent with what we use for the key button in the toolbar for 2D scenes.

@skyace65
Copy link
Contributor Author

Updated description again, ready for review again.

@skyace65 skyace65 requested a review from fire February 18, 2024 15:50
@akien-mga
Copy link
Member

akien-mga commented Jul 29, 2024

Needs rebase.

Edit: Rebased myself.

@akien-mga akien-mga dismissed fire’s stale review July 30, 2024 10:24

Changes done.

@akien-mga akien-mga merged commit 72315d5 into godotengine:master Jul 30, 2024
17 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skeleton3D Insert Key button is impossible to read
6 participants