Add an Advanced Options toggle to the editor export preset
#88419
Conversation
m4gr3d
force-pushed
the
add_export_preset_advanced_options_toggle
branch
from
f56763a
to
3e39a95
Compare
| return; | ||
| } | ||
| advanced_options_enabled = p_enabled; | ||
| EditorExport::singleton->save_presets(); |
There was a problem hiding this comment.
Why do we need to save the presets when this is changed?
There was a problem hiding this comment.
I followed the pattern used for runnable; from reading the code, we persist metadata about a preset everytime it's modified, so I did the same for this new field.
m4gr3d
force-pushed
the
add_export_preset_advanced_options_toggle
branch
2 times, most recently
from
c6135dc
to
846652e
Compare
|
I think Runnable should be placed on top of Advanced Options, instead of the other way around. This way, Advanced Options will be closer to the view it affects (the list of export options). |
|
It does peeve me that it occupies a whole new line instead of being alongside the "Runnable" toggle. I understand why that is, but it does look odd. |
m4gr3d
force-pushed
the
add_export_preset_advanced_options_toggle
branch
2 times, most recently
from
d87cd5d
to
5c4f845
Compare
@Mickeon I played around with keeping them on the same line. Let me know what you think
|
|
I do like it myself, but it may break a few editor UX rules. @Calinou may know best. At worst it is reverted. |
|
Putting them side-by-side is ideal to me 🙂 I was concerned you could confuse the two buttons together (since the checkbutton icon that appears on the left of Runnable could be confused to be for that setting). However, I'd say the different text color when the button is checked makes it unambiguous enough. If there's a strong need, we can have an Separator node placed between the two buttons, but I think this is good to go as-is for now. |
m4gr3d
force-pushed
the
add_export_preset_advanced_options_toggle
branch
from
5c4f845
to
6ef3154
Compare
|
Thanks! |
Similar to the
Project Settings, add anAdvanced Optionstoggle to the editor export presets to allow hiding advanced options and simplify the UI.Follow up of the discussion with @dsnopek on #88297 (comment).
This PR sets up the infra and hides Android advanced options; other platform maintainers can leverage the same logic to hide options they deem advanced for their platform.
Screen_Recording_20240216_141113_Godot.Editor.4.debug.mp4