[Editor] Hide Search Results by default and show it on first search. #88465
Conversation
AeioMuch
force-pushed
the
search_results_button
branch
2 times, most recently
from
e86ce24
to
fe96e6a
Compare
|
Works as expected, implements everything from the proposal Didn't look at the code |
AeioMuch
force-pushed
the
search_results_button
branch
from
fe96e6a
to
9bd64ff
Compare
|
Since one of the build failed because of memory leak I pushed a new commit where I've tried to do it a bit differently : The I hope this change will help with those apparent memory leaks, since my guess was that the button needed to be added in the constructor to be properly cleaned afterwards, and that's how it was done before. If that was not the issue then honestly I don't know why, and sorry for the inconvenience! |
@RPicster tagging you because you mentioned that you're using search results in the scene view for navigation somehow. I personally can't make it work, when I click on those nothing changes in the 3D view for me, but if it works for you this change would likely break it, so pls comment |
AeioMuch
force-pushed
the
search_results_button
branch
3 times, most recently
from
acae627
to
3de179e
Compare
AeioMuch
changed the title
I think you can just forget what I said :D Watching my own behaviour I think it's not important. |
AThousandShips
changed the title
…t the end. Add a close button to hide it back. Also switch to Script Editor if a searched line is clicked.
AeioMuch
force-pushed
the
search_results_button
branch
from
3de179e
to
5cf6f3c
Compare
[Editor] Hide Search Results by default and show it on first search.
akien-mga
closed this pull request by merging all changes
into
godotengine:master
in
0acfb38
|
Thanks! |
Bugsquad edit: fixes godotengine/godot-proposals#9114
This PR aims to implement this proposal : godotengine/godot-proposals#9114
This add the find_in_files_button only when the first search to find in files is made so that it is placed in the last position.This shows the find_in_files_button only when the first search to find in files is made and push it in the last position.
It also add a Close button that hide the panel and its button when the user want it. I choose to keep the Search Results open even when switching away from the Script editor since the Close button is now available to hide it at will.
Also switch to the script editor when the user click on a line found.
This is my first PR on the editor and found the above proposal was fitting to be an easy first attempt. I tried to avoid doing stupid things and from my test I did not find any issue, but let me know if I did something stupid...