Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak property order in the inspector for TabBar #88477

Merged
merged 1 commit into from
Feb 18, 2024
Merged

Tweak property order in the inspector for TabBar #88477

merged 1 commit into from
Feb 18, 2024

Conversation

jsjtxietian
Copy link
Contributor

Fixes #88434

As suggested in #88434 (comment), I did some test myself and it seems fine to fix it this way. Feel free to correct me

@jsjtxietian jsjtxietian requested a review from a team as a code owner February 18, 2024 04:56
@AThousandShips AThousandShips added this to the 4.3 milestone Feb 18, 2024
AThousandShips
AThousandShips approved these changes Feb 18, 2024
View reviewed changes
Copy link
Member

@AThousandShips AThousandShips left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this works correctly (though discovered another bug while testing this, will look into that)

Done:

@AThousandShips AThousandShips mentioned this pull request Feb 18, 2024
Merged
@akien-mga akien-mga merged commit 3b649d2 into godotengine:master Feb 18, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@jsjtxietian jsjtxietian deleted the tab-down branch February 19, 2024 02:10
@kitbdev kitbdev mentioned this pull request Sep 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
bug topic:editor topic:gui usability
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

TabBar has a foldable Tabs section above properties that do not belong to it
4 participants
@jsjtxietian @akien-mga @KoBeWi @AThousandShips