[Windows] Make D3D12 loading dynamic to support pre-Windows 10 versions. #88496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested build with D3D12 enabled on Windows 7, it is loading (D3D12 obviously is not working):
|
|
I would like to take a step back for a moment and reassess if dynamic loading is worth it, considering the amount of patches and compexity it's adding. What's the advantage to it? |
Windows 7/8/8.1 support by official binaries, I do not think there's any other advantage.
It's only 10 calls (5 in the engine + single helper header patch), and not much complexity, if it was something like GLAD I would not consider it, but something like this looks acceptable to me. |
|
I was unaware of the issues pre-Win-10. If even Windows 8.x needs it, then I quite see the advantage. |
bruvzg
force-pushed
the
d3d12_dyn_load
branch
from
3e3c5b8
to
f4ca6a8
Compare
akien-mga
approved these changes
Mar 5, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88466, supersede #88486
Also include checks and fixes from #88486