Add a h_separation between icons in CheckButton/CheckBox
#88615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `h_separation` between internal elements and custom elements was added when `text` was not empty. That is, this `h_separation` does not exist when there is a valid custom `icon` but `text` is empty. Now, the `h_separation` between the internal element and the custom element is added when the internal element and any custom element exist (both width are greater than `0`).
Rindbee
force-pushed
the
add-h_separation-between-icons-in-CheckButton-and-CheckBox
branch
from
f964bf3
to
5de496d
Compare
KoBeWi
approved these changes
Feb 25, 2024
|
Thanks! |
Rindbee
deleted the
add-h_separation-between-icons-in-CheckButton-and-CheckBox
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
h_separationbetween internal elements and custom elements was added whentextwas not empty. That is, thish_separationdoes not exist when there is a valid customiconbuttextis empty.Now, the
h_separationbetween the internal element and the custom element is added when the internal element and any custom element exist (both width are greater than0).Fix #88505.