Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Run Instances Dialog #88685

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Improve Run Instances Dialog #88685

merged 1 commit into from
Feb 23, 2024

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Feb 22, 2024

Small improvements to the dialog:

  • moved main arguments and features to be next to each other
  • added placeholders to clarify usage
  • squashed instance count

Before:
image

After:
image

@seppoday
Copy link

I guess this kind of design might work?
image

@KoBeWi
Copy link
Member Author

KoBeWi commented Feb 23, 2024

This makes the instance count disjointed from the list 🤔
Also the counter would be better on the left probably.

@Calinou
Copy link
Member

Calinou commented Feb 23, 2024

I like @seppoday's mockup but I'd put the instance count on the left too.

@KoBeWi
Copy link
Member Author

KoBeWi commented Feb 23, 2024

image

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Feb 23, 2024
@akien-mga akien-mga merged commit b17456b into godotengine:master Feb 23, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants