Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Fix some experimental/deprecated hints #88708

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Feb 23, 2024

Two cases from the recent rendering PR that went unnoticed, and some cases that have a deprecated or experimental message but doesn't use the property

Can remove some of those if they are incorrect, but I think they match, if they have the message in the description I don't think there's an issue making it an "official" tag

Left some of the cases in the Android export in a separate commit for simplicity, as they are specific to an API level, will restore them if they're unwanted

@AThousandShips AThousandShips added this to the 4.3 milestone Feb 23, 2024
@AThousandShips AThousandShips requested review from a team as code owners February 23, 2024 14:25
@AThousandShips AThousandShips changed the title Experimental docs [Docs] Fix some experimental/deprecated hints Feb 23, 2024
Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Android updates look good!

@Mickeon
Copy link
Contributor

Mickeon commented Feb 23, 2024

For all of these, there's no need to repeat "This is experimental", and explain what "experimental" means because the mere existence of the message infers it.

@AThousandShips
Copy link
Member Author

Can reword the ones that do slightly :)

doc/classes/Compositor.xml Outdated Show resolved Hide resolved
doc/classes/CompositorEffect.xml Outdated Show resolved Hide resolved
doc/classes/NavigationRegion2D.xml Outdated Show resolved Hide resolved
doc/classes/ProjectSettings.xml Outdated Show resolved Hide resolved
platform/web/doc_classes/EditorExportPlatformWeb.xml Outdated Show resolved Hide resolved
doc/classes/CompositorEffect.xml Outdated Show resolved Hide resolved
doc/classes/Compositor.xml Outdated Show resolved Hide resolved
doc/classes/NavigationRegion2D.xml Outdated Show resolved Hide resolved
doc/classes/ProjectSettings.xml Outdated Show resolved Hide resolved
doc/classes/SkeletonModification2DPhysicalBones.xml Outdated Show resolved Hide resolved
@AThousandShips
Copy link
Member Author

Thank you! Added these changes

Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surely more of these won't pop up again now, right?

@AThousandShips
Copy link
Member Author

There are no uses of "experimental" outside of these tags now in my search, or "deprecated"

@Mickeon
Copy link
Contributor

Mickeon commented Feb 23, 2024

Yeah but as this PR needed to happen there may be some others that may be merged without noticing the new deprecated/experimental message.

@AThousandShips
Copy link
Member Author

That's true, but keeping an eye for those, but good point

@akien-mga akien-mga merged commit 09c58ed into godotengine:master Feb 23, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@AThousandShips AThousandShips deleted the experimental_docs branch February 23, 2024 21:30
@AThousandShips
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants