Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenXR: Register eye gaze even when disabled #88754

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

BastiaanOlij
Copy link
Contributor

When we added the option to gate certain extensions, we implemented this such that the extension is not registered at all.
For the eye gaze interaction extension we need to make an exception because this extension also registers meta data for our action map. If it doesn't do this our action map UI will fail when interactions have been added to the action map, but the action map UI is unable to make sense of this.
Instead the extension simply remains disabled.

Fixes #86358

@BastiaanOlij BastiaanOlij added this to the 4.3 milestone Feb 24, 2024
@BastiaanOlij BastiaanOlij self-assigned this Feb 24, 2024
@dsnopek dsnopek requested a review from a team February 24, 2024 15:59
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me, and it fixes the issue in my testing!

From one of your earlier comments:

There is also a question whether it makes sense to add the eye gaze interaction to the default action map. I think we should remove that bit.

This PR doesn't do that. Should we add that here?

What's here already is great, so I don't think that should necessarily hold it back - we could certainly do that in a follow-up PR as well.

@BastiaanOlij
Copy link
Contributor Author

@dsnopek for now I decided to keep it in the action map. The problem with removing it is that when someone enabled eye gaze interaction, it won't immediately work. While part of me in answer to that says RTFM, seeing it is now properly filtered out it doesn't do much harm.

@akien-mga akien-mga merged commit f91e74a into godotengine:master Feb 26, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@BastiaanOlij BastiaanOlij deleted the fix_openxr_eye_gaze_init branch February 26, 2024 11:24
@dsnopek
Copy link
Contributor

dsnopek commented Feb 26, 2024

@BastiaanOlij Ok, sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenXR Errors After First Tutorial Page
4 participants