Pre-commit: Update to clang-format 17.0.6 and black 24.2.0 #88959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
enhancement
topic:buildsystem
cherrypick:3.x
akien-mga
commented
Feb 28, 2024
| @@ -1415,7 +1415,7 @@ static void gdextension_editor_help_load_xml_from_utf8_chars(const char *p_data) | |||
| #endif | |||
| } | |||
|
|
|||
| #define REGISTER_INTERFACE_FUNC(m_name) GDExtension::register_interface_function(#m_name, (GDExtensionInterfaceFunctionPtr)&gdextension_##m_name) | |||
| #define REGISTER_INTERFACE_FUNC(m_name) GDExtension::register_interface_function(#m_name, (GDExtensionInterfaceFunctionPtr) & gdextension_##m_name) | |||
There was a problem hiding this comment.
This change is technically "wrong" as per our code style for references, but it seems whatever fix they made in clang-format 17 for the handling of math operators in macros has a bit of an issue with reference/pointer operators.
Overall it shouldn't be a big issue, and maybe future clang-format versions will fix it back.
There was a problem hiding this comment.
@akien-mga is this issue reported?
There was a problem hiding this comment.
Now yes :) llvm/llvm-project#83400
adamscott
approved these changes
Feb 28, 2024
akien-mga
removed
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A big advantage of the move to
pre-commitis that we can pin style checking dependencies for everyone, so there's no more concern updating to clang-format 17 even though its output differs slightly from versions 13 to 16 which we supported prior to this.pre-commitPython tool #88866.