Fix linking NavigationServer2D/3D with all classes disabled in build profile #88986
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the destructor for NavigationMeshSourceGeometryData2D/3D being implemented in the .cpp was causing linking issues.
I was testing making minimal sized export templates with the following command:
And this build profile which disables nearly all classes in the engine, generated from a blank project with just icon.svg, so that's the only type of resource it needs to support: blank.build.txt
I would get this linking issue:
I was puzzled to have this issue with NavigationMeshSourceGeometryData2D but not NavigationPolygon, when both are used as
Ref<T>
in NavigationServer2D. Comparing both classes, the main difference seemed to be the destructor implemented in the .cpp, and moving it solved the issue. The rest of the changes are just for consistency.I don't really know why this fixes the linking issue, or why it happened before this fix. Maybe someone more versed in C++ can clarify :)