Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[.NET] Fix interpolated strings in ScriptPropertyDefVal #89007

Conversation

paulloz
Copy link
Member

@paulloz paulloz commented Feb 29, 2024

@paulloz paulloz added this to the 4.3 milestone Feb 29, 2024
@paulloz paulloz requested a review from a team as a code owner February 29, 2024 12:01
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we only care about the ScriptPropertyDefVal generator for these tests, we could add the exported fields to a separate file so we only need to add the GeneratedSources for *_ScriptPropertyDefVal.generated.cs. And then make a new test in ScriptPropertyDefValGeneratorTests.cs.

Also, do we want to add a test for nested string interpolation? For example: $"The quick brown fox jumps over {GD.VarToStr($"the lazy {Engine.GetVersionInfo()}")}";

@paulloz paulloz force-pushed the dotnet/fix-interpolated-string-scriptpropertydefval branch from 402dfc4 to 1733928 Compare February 29, 2024 19:37
@paulloz paulloz force-pushed the dotnet/fix-interpolated-string-scriptpropertydefval branch from 1733928 to 4223328 Compare March 1, 2024 10:39
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@akien-mga akien-mga merged commit 6315429 into godotengine:master Mar 4, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@paulloz paulloz deleted the dotnet/fix-interpolated-string-scriptpropertydefval branch March 4, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[.NET] Interpolated strings as exported member's default value break source generation
3 participants