Fix fundamental type misuse in math arguments #89148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate of: As far as I can tell every case is covered by my older PR (Though I had missed Delaunay, updated that) |
|
One of these days I'll remember to actually check other PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A handful of the core math classes were using their fundamental type arguments inappropriately, generally through unnecessary
constand/or passing by reference. This PR sweeps through all those files, ensuring fundamental type arguments aren'tconst& get passed by value (unless deliberately functioning as an "out" reference). Besides that, the only other change made is to Vector3'ssnapandsnappedfunctions to fix the opposite issue, where Vector3 wasn't passed by reference previously.