Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ShaderDescription and related types public #89277

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

RandomShaper
Copy link
Member

ShaderDescription is used as a return parameter in one of the public functions of RenderingDeviceDriver, so it makes little sense that such structs were protected, hidden from the same scope that can call the mentioned function if directly dealing with the driver.

@RandomShaper RandomShaper added this to the 4.3 milestone Mar 8, 2024
@RandomShaper RandomShaper requested a review from a team as a code owner March 8, 2024 08:59
@akien-mga akien-mga merged commit ffc41fb into godotengine:master Mar 8, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@RandomShaper RandomShaper deleted the rdd_public_shader_desc branch March 10, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants