-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use [codeblock lang=text]
more often in class reference
#89316
Use [codeblock lang=text]
more often in class reference
#89316
Conversation
I've looked at every 1. Files in which you missed something. Godot Shader Language, JSON, XML, formulas, pseudographics and other. For some snippets, GDScript highlighting may be suitable, I just noted for completeness, we can discuss each case.
2. By the way, I noticed a few other problems. Suggestions:
|
I mean, I could've solved those problems in a separate PR. I've noticed a few of these myself.
I actually would've preferred the opposite! That is, merging the codeblock couple in GlobalScope, as it keeps the example more concise and focused. When I see two codeblocks, I think they're entirely unrelated examples (it also avoids the kinda ugly "Prints" in the middle). Bring the sword and let's play fencing over this.
|
aeabc5b
to
2539a10
Compare
|
2539a10
to
b211d82
Compare
Aaah, there you go. Thank you. But you see what I mean? That could easily be reworded another way without the codeblock. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Needs a rebase though :(
b211d82
to
328b007
Compare
Rebased after minor conflict. |
Thanks! |
Looooook at @dalexeev leaving the dirty work for me, aye? See #89263 .