-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rendering] Add hints to some uniform PropertyInfo
s
#89488
Conversation
I'll be experimenting with some improvements to property handling perhaps this weekend, would start with experimenting with remapping unsinged integers to be edited correctly, that should be relatively straight forward to do, adding it as a hint string Might also look at adding special constants to the range to help with things, like
|
6c4a9f0
to
bd7b9e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a nice improvement!
Should be squashable before merge. |
* Enforce range on `int/uint` * Use flags for `bvec2/3/4` arrays
bd7b9e6
to
6ff6a11
Compare
Thanks! |
Thank you! |
int/uint
bvec2/3/4
arraysLeft some
TODO
notes for possible future improvements, unsure what can be one with them but good to add if we end up improving other contextsFull change can't be cherry picked as it depends on arrays having hints, but can cherry pick specifically the
int/uint
case if desired