Expose DEVICE_ID_EMULATION constant in InputEvent
#89526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sauermann
reviewed
Mar 15, 2024
Calinou
force-pushed
the
inputevent-add-emulation-internal-constants
branch
from
e1c5157
to
0dab06c
Compare
Calinou
changed the title
DEVICE_ID_{EMULATION,INTERNAL} constants in InputEventDEVICE_ID_EMULATION constants in InputEvent
Calinou
changed the title
DEVICE_ID_EMULATION constants in InputEventDEVICE_ID_EMULATION constant in InputEvent
This also improves the documentation related to emulated InputEvents.
Calinou
force-pushed
the
inputevent-add-emulation-internal-constants
branch
from
0dab06c
to
6818e50
Compare
Sauermann
approved these changes
Mar 17, 2024
There was a problem hiding this comment.
As noted in #24589 (comment)
exposing this makes sense to me. Implementation looks correct.
akien-mga
added a commit
that referenced
this pull request
Mar 24, 2024
…nal-constants Expose `DEVICE_ID_EMULATION` constant in InputEvent
akien-mga
closed this pull request by merging all changes
into
godotengine:master
in
06abc86
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also improves the documentation related to emulated InputEvents.