GLTF: Extract converting hull points to mesh to a helper function #89542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire
approved these changes
Mar 16, 2024
akien-mga
added a commit
that referenced
this pull request
Mar 24, 2024
GLTF: Extract converting hull points to mesh to a helper function
akien-mga
closed this pull request by merging all changes
into
godotengine:master
in
06abc86
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a situation downstream where I needed this functionality in 2 places, so I separated it into a helper method. I believe this is worth upstreaming, since this method is quite a big chunk of isolated code that makes sense to separate to improve organization. The behavior should be identical except for printing another error message when failing.