Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Enable submodules on the checkout action #89552

Merged
1 commit merged into from
Mar 24, 2024

Conversation

aaronfranke
Copy link
Member

This does not directly alter the behavior for Godot itself, but it means that forks of Godot with submodules do not need to apply a patch to the CI scripts in order for the CI to build with the submodules. The Godot repo itself has no submodules, and therefore this does nothing, there are no downsides for us, but it benefits forks.

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@akien-mga akien-mga closed this pull request by merging all changes into godotengine:master in 06abc86 Mar 24, 2024
akien-mga added a commit that referenced this pull request Mar 24, 2024
CI: Enable submodules on the checkout action
@akien-mga
Copy link
Member

Thanks!

@aaronfranke aaronfranke deleted the ci-submodules branch March 24, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants