Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TextEdit selection end of line drawing for wrapped lines and gaps #89625

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

kitbdev
Copy link
Contributor

@kitbdev kitbdev commented Mar 17, 2024

There were a couple of issues with the end of line drawing.
Fixes it being applied to all lines of wrapped text when the selection extended past it, instead of only the last one:

godot te wrapped line end

Fixes occasional gaps or overlaps.
I can reproduce it only on certain lines of text and it changes based on zoom factor. It also depends on where the top of the selection is, usually at the start of a word:

image

Fixes very small 1px selection end moving when the selection start is moved sometimes:

godot te select end jitter

Edit: Made sure it works with rtl text at the end of the line.

@kitbdev kitbdev requested a review from a team as a code owner March 17, 2024 23:04
@YeldhamDev YeldhamDev added this to the 4.3 milestone Mar 18, 2024
@akien-mga akien-mga merged commit 37766c4 into godotengine:master Mar 26, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@kitbdev kitbdev deleted the not-the-end-of-the-line branch March 26, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants