Fix some build errors with disable_3d=yes
#89760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
commented
Mar 21, 2024
| @@ -124,6 +123,7 @@ | |||
| #include "tests/test_validate_testing.h" | |||
|
|
|||
| #ifndef _3D_DISABLED | |||
| #include "tests/scene/test_arraymesh.h" | |||
There was a problem hiding this comment.
The tests for ArrayMesh all depends on 3D specific code, like the primitive meshes, so there's no use testing it at all without 3D enabled
AThousandShips
force-pushed
the
no_3d_fix_3
branch
from
248f5f0
to
abe7ec1
Compare
akien-mga
approved these changes
Apr 16, 2024
lawnjelly
approved these changes
Apr 16, 2024
aaronfranke
approved these changes
Apr 17, 2024
|
Thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some new issues with 3D disabled popped up after recent changes, it now once again works correctly (and tests run properly)
These are all test related and won't be caught by the CI, as it doesn't build minimal debug builds, and 3D can't be disabled in the editor