Apply vertex attribute fixing to the LOD system for rigged meshes. #90180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire
force-pushed
the
lock-primary-base-influence
branch
24 times, most recently
from
07cf5e4
to
3e57b0d
Compare
lyuma
reviewed
Apr 4, 2024
scene/resources/3d/importer_mesh.h
Outdated
Comment on lines
85
to
88
| struct MergedAttribute { | ||
| Vector3 normal; | ||
| Vector<int> primary_bone_influence; | ||
| }; |
There was a problem hiding this comment.
This should not have a Vector<int> for every vertex. it is inefficient, especially given that there is at most a small constant number of influences per vertex
I think it should be possible with one influence and one weight, maybe two influences at most but I'd like to see a counter-example.
Remember that mesh simplify will try to avoid merging vertices with different values here:
Even if the vertex contains a lot more influences, the one or two most dominant influences should be enough to ensure the vertices are considered different.
There was a problem hiding this comment.
The linked issue ‘s glb fails to decimate correctly if we limit to one or two influences.
There was a problem hiding this comment.
Limited to 1 influence
Screen.Recording.2024-04-04.at.8.34.21.AM.mov
Limited to 8 influences
Screen.Recording.2024-04-04.at.8.35.53.AM.mov
fire
force-pushed
the
lock-primary-base-influence
branch
10 times, most recently
from
b2fe1c1
to
3f677f0
Compare
fire
force-pushed
the
lock-primary-base-influence
branch
7 times, most recently
from
9d7b2e8
to
870f4f5
Compare
fire
force-pushed
the
lock-primary-base-influence
branch
2 times, most recently
from
1cd0988
to
220751e
Compare
fire
force-pushed
the
lock-primary-base-influence
branch
4 times, most recently
from
220751e
to
ddac36a
Compare
Adjust attribute weights and array sizes for LOD generation. Increase maximum attributes to 32 in rescaleAttributes function
fire
force-pushed
the
lock-primary-base-influence
branch
from
ddac36a
to
c69d8e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #84479
Here's a sample video with me toggling the mesh lod settings in the background.
Godot Engine autolod patch rig lod success 02
https://youtu.be/JodufVyd3Ow and https://youtu.be/BMvh1J9ril0