Fix sharing World2D between SubViewports causes 2D lights of one SubViewport to go missing #90282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…viewport worlds are shared
fire
changed the title
KoBeWi
approved these changes
Apr 8, 2024
akien-mga
changed the title
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where Light2D is seemingly lost or invisible when its parent SubViewport's world_2d is set to another SubViewport's. Originally Light2D only reattached itself to a canvas on the NOTIFICATION_ENTER_TREE notification. Since in the world-sharing use case the Light2D is not entering the node tree, it remained associated with the canvas of the orignal world. The update uses the NOTIFICATION_ENTER_CANVAS and NOTIFICATION_EXIT_CANVAS notifications instead. This brings Light2D in line with LightOccluder2D which works fine.
Edited:
Fixes: #84221