Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove border roundness inside panels of AcceptDialog windows #90283

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

YeldhamDev
Copy link
Member

It's quite hard to notice, but it's there.

Before: After:
Screenshot_20240405_200610 Screenshot_20240405_195727

@YeldhamDev YeldhamDev added this to the 4.3 milestone Apr 5, 2024
@YeldhamDev YeldhamDev requested a review from a team as a code owner April 5, 2024 23:09
@YeldhamDev YeldhamDev changed the title Remove border roundness of AcceptDialog windows Remove border roundness inside panels of AcceptDialog windows Apr 6, 2024
@akien-mga
Copy link
Member

theyre-the-same-picture-the-office

Copy link
Contributor

@MewPurPur MewPurPur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spotted the difference!

@akien-mga it's a little transparent dot right under the close button, a little to the right.

I'm a bit confused how this change addresses it, honestly.

@AThousandShips
Copy link
Member

It is because the panel exposed a tiny bit of the lighter background

@akien-mga akien-mga merged commit e5b4ef8 into godotengine:master Apr 6, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@YeldhamDev YeldhamDev deleted the pure_squares branch April 6, 2024 13:56
@piramidamsc
Copy link

piramidamsc commented Apr 6, 2024

I spotted the difference!

@akien-mga it's a little transparent dot right under the close button, a little to the right.

I'm a bit confused how this change addresses it, honestly.

yes, indeed, and I thought it was a speck of dust on the monitor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants