CommandQueueMT: Fix flush re-entrancy #90470
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CommandQueueMT
re-entrancy was broken two-fold:WorkerThreadPool
(thread_enter
/exit_command_queue_mt_flush()
) doesn't have a concept of stack or ref counting.This PR fixes re-entrancy issues by just early-returning. The result will be the same as if re-entrancy had been detailedly fixed so it was possible without issues, but wihout getting a deeper stack.
Fixes #90363.