Use fmod for navigation mesh border size warning #90602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smix8
force-pushed
the
bsfmod
branch
2 times, most recently
from
8283b23
to
85f0b97
Compare
aaronfranke
reviewed
Apr 13, 2024
Uses fmod for checking that navigation mesh border size matches the cell size as a multiple of cell size is also valid.
aaronfranke
approved these changes
Apr 13, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses fmod for checking that navigation mesh
border_sizematches thecell_sizeas a multiple of cell size is also valid.Also removes
is_equal_approx()in this case as having the numbers not match exactly will cause edge seams on very small cell sizes which goes against the idea of using a border size in the first place.