Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Fix incorrect reference to input_pickable #90622

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

AThousandShips
Copy link
Member

Causes sphinx build on godot-docs to fail

@AThousandShips AThousandShips added this to the 4.3 milestone Apr 13, 2024
@AThousandShips AThousandShips requested a review from a team as a code owner April 13, 2024 13:42
@AThousandShips AThousandShips added cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Apr 13, 2024
@akien-mga
Copy link
Member

How come there is no warning/error when running make_rst.py?

@AThousandShips
Copy link
Member Author

AThousandShips commented Apr 13, 2024

Probably because there is an override in PhysicsBody2D, will look at the docs data

Edit: It doesn't have a label in the rst as it's just an override, but the property technically exists, so it's not possible to directly reference it, but it's there, so the make_rst.py doesn't catch it

Probably some missing check in the properties validation somewhere but I don't know where the specific validation is run, can dig later and see if I can add a safer check there

@akien-mga akien-mga merged commit b2b51e1 into godotengine:master Apr 13, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@AThousandShips AThousandShips deleted the doc_fix branch April 13, 2024 14:42
@AThousandShips
Copy link
Member Author

Thank you!

@akien-mga
Copy link
Member

Cherry-picked for 4.2.3.
Cherry-picked for 4.1.5.

@akien-mga akien-mga removed cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants