Rename internal is_ascii_char
to is_ascii_alphabet_char
#90931
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning: This is the non-numeric version of
is_ascii_alphanumeric_char
.is_ascii_char
can be misleading because it could imply all ASCII characters, including numbers, symbols, and control characters. Since this method explicitly only checks for alphabetical characters, it should be calledis_ascii_alphabet_char
(or similar).