Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce using .NET SDK >= 8 #91079

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

paulloz
Copy link
Member

@paulloz paulloz commented Apr 23, 2024

As discussed on 🚀

Officially enforce that we are building the .NET projects with SDK 8.

Since the lookup for global.json starts in the current working directory (and not in the project directory), I had to modify our Python script to make sure we run our MSBuild commands from the modules/mono/ folder.

Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great. I imagine most contributors have upgraded to 8.0 by now.

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Apr 24, 2024
@akien-mga akien-mga merged commit ba3007d into godotengine:master Apr 24, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@paulloz paulloz deleted the dotnet/enforce-use-sdk-8 branch April 24, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.NET SDK 6.0 can't be used anymore to build C# solutions in a project
3 participants