Fix incorrect memory read when capacity changes in RD Graph. #91312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomShaper
approved these changes
Apr 29, 2024
clayjohn
approved these changes
Apr 29, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally spotted by @darksylinc, ASAN randomly reported a rare error that could happen when checking dependencies in the render graph. If the command list was resized and capacity increased, the internal contents of the vector would be re-allocated. This usually imposes no problems as all accesses are done through indices, but in this particular bit of code, a reference was held to the element and used after the potential resize could happen.
The end result was likely benign in most cases, but upon a code review the fix makes sense. No behavior changes should be expected. This change is only relevant to 4.3.