Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FBX: Print ufbx load warnings on import #91529

Merged
merged 1 commit into from
May 7, 2024

Conversation

bqqbarbhg
Copy link
Contributor

This PR adds printing of warnings reported by ufbx when importing files. This could help in diagnosing errors when users try to import half-broken files with half-broken results. ufbx itself is quite silent about warnings, so these should only be issued when there's something truly wrong with the file, in a way that might make the imported scene broken in some ways.

@bqqbarbhg bqqbarbhg requested a review from a team as a code owner May 3, 2024 18:58
@bqqbarbhg
Copy link
Contributor Author

Initial dataset testing indicates that even though errors are rare, some badly behaving files will spam an astounding amount of errors (one file so far has issued a whopping 29088 warnings). I'll probably implement a per-type warning limit to ufbx to prevent such cases, but for now (and maybe even in general) we'd want to limit the maximum amount of warning spam on Godot side as well.

fire
fire previously requested changes May 4, 2024
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having that amount of warning messages sounds like it causes other problems of causing editor stuttering. I am not sure how to resolve.

@bqqbarbhg
Copy link
Contributor Author

Limited the maximum errors to 10 per type. Also added element names (like nodes or meshes that prompt the warning) to the warnings.

@lyuma lyuma dismissed fire’s stale review May 7, 2024 09:11

the new version includes a warning limit of 10 which should reduce 99% of the stuttering in the above example

@akien-mga akien-mga merged commit 82e77ea into godotengine:master May 7, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants