Do not use MSAA versions of textures on debug views. #91808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayjohn
approved these changes
May 12, 2024
Calinou
approved these changes
May 12, 2024
There was a problem hiding this comment.
Tested locally, it works as expected. The issue no longer occurs on the same setup as in #62955 (comment).
The normal buffer view looks a bit strange when MSAA is enabled (it's also not smoothed out), but I guess not much can be done about this.
| Disabled | 2× MSAA | 4× MSAA | 8× MSAA |
|---|---|---|---|
 |
 |
 |
 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on debugging the motion vectors, I noticed the code will fail to work if MSAA is enabled in the viewport. This error also happens when trying to view the normal roughness buffer when MSAA is enabled.
Since the debug effects do not support sampling from Multisampled textures directly, and this is the only use case where these methods are called, the most effective solution is to only ever return the resolved versions of the textures, which are ready by the time the debug effects are drawn.
This issue is not a regression from any particular change as far as I can tell.
Fixes #62955.