Editor: Ensure font image rows/columns are positive #91829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
changed the title
alesliehughes
force-pushed
the
editor_font_image
branch
from
c9fde5f
to
a47033a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
alesliehughes
force-pushed
the
editor_font_image
branch
from
a47033a
to
82f5bd6
Compare
|
Pushed the correct change this time. |
bruvzg
approved these changes
May 11, 2024
AThousandShips
approved these changes
May 11, 2024
alesliehughes
force-pushed
the
editor_font_image
branch
from
82f5bd6
to
b973a01
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check on the import for valid Rows/Columns.
Add some restrictions to the GUI to disallow values <= 0.
Fixes #91812