Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web] Fix quotes style in HTML shell head include #91856

Merged
merged 1 commit into from
May 13, 2024

Conversation

patwork
Copy link
Contributor

@patwork patwork commented May 11, 2024

Info

As we use double quotes in the HTML tags, I would like to propose a fix to the platform/web/export/export_plugin.cpp code that adds headings related to icons and the PWA manifest.

Difference

Before:

<link id='-gd-engine-icon' rel='icon' type='image/png' href='mygame.icon.png' />
<link rel='apple-touch-icon' href='mygame.apple-touch-icon.png'/>
<link rel='manifest' href='mygame.manifest.json'>

After:

<link id="-gd-engine-icon" rel="icon" type="image/png" href="mygame.icon.png" />
<link rel="apple-touch-icon" href="mygame.apple-touch-icon.png"/>
<link rel="manifest" href="mygame.manifest.json">

@patwork patwork requested a review from a team as a code owner May 11, 2024 23:45
@AThousandShips AThousandShips added this to the 4.3 milestone May 13, 2024
@akien-mga akien-mga merged commit 10cd6ad into godotengine:master May 13, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants