Editor Feature Profile: Only rebuild selected TreeItem and all children when a property is edited #92136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
May 20, 2024
…en when a property is edited
Maran23
force-pushed
the
editor-feature-profile-improvements
branch
from
63038be
to
7008111
Compare
AThousandShips
approved these changes
May 20, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #92132
Before, the whole
Treewas rebuild when a property was changed.This is not just a bad idea for performance reasons, but also does not retain any folds that were previously done by the user on any other
TreeItem.This PR improves that by only rebuilding the selected class
TreeItemand all children, which improves the performance but also retain any folds that were previously done to otherTreeItems.For that, we now always call
_update_profile_tree_fromwhen something was edited instead of_update_selected_profile, which does a full rebuild.unknown_2024.05.20-02.25.mp4