Fix confusing descriptions of ConfirmationDialog. #92242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daylily-Zeleen
changed the title
akien-mga
added
cherrypick:4.1
akien-mga
approved these changes
May 22, 2024
akien-mga
reviewed
May 22, 2024
| [/gdscript] | ||
| [csharp] | ||
| GetCancelButton().Pressed += Canceled; | ||
| GetCancelButton().Pressed += OnCanceled; |
There was a problem hiding this comment.
CC @godotengine/dotnet to confirm this would be the appropriate name style for a signal callback.
There was a problem hiding this comment.
.NET conventions use On* to name methods used to raise events, not for callbacks. But our own documentation already does not follow this convention (e.g. https://docs.godotengine.org/en/latest/tutorials/scripting/c_sharp/c_sharp_signals.html). So I guess it is fine?
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code example
get_cancel_button().pressed.connect(self.canceled)is confusing, Becausecanceledis a signal of base classAcceptDialog. Connect a signal to signal is incorrect obviously.