Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix script properties being lost and prevent node reference corruption upon scene reimport #92279

Merged
merged 2 commits into from
May 29, 2024
Merged

Fix script properties being lost and prevent node reference corruption upon scene reimport #92279

merged 2 commits into from
May 29, 2024

Commits on May 28, 2024

  1. Changes the scene reimport function to handle some crash edge cases: 

    * The reimported instance attempt to preserve ownerless nodes.
* A recursive function call to '_nodes_scene_reimported' so these can be recreated if required.
* Clears instance scene_state on new instantiated replacement nodes.
    @SaracenOne @fire
    SaracenOne authored and fire committed May 28, 2024
    Configuration menu
    Copy the full SHA
    846bafd View commit details
    Browse the repository at this point in the history

  2. Updated scene hot-reloading: 

    Preserves exported script variables
Prevents corruption of direct node references.
    @SaracenOne @fire
    SaracenOne authored and fire committed May 28, 2024
    Configuration menu
    Copy the full SHA
    e57312d View commit details
    Browse the repository at this point in the history