Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use current mouse button state instead of saved values. #92424

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented May 27, 2024

Same as #92415, but for mouse buttons.

@bruvzg bruvzg force-pushed the mouse_state branch 3 times, most recently from 627784b to ed1d157 Compare May 30, 2024 10:20
@bruvzg bruvzg marked this pull request as ready for review May 30, 2024 10:35
@bruvzg bruvzg requested review from a team as code owners May 30, 2024 10:35
Copy link
Contributor

@Riteo Riteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave a look, things look fine!

I think that the freelook fix bundled is more of a workaround (see #92455 (comment) ) but it will do for now.

I also researched a bit on the Wayland side and things aren't bad at all. There's a bit of a focus tracking bug in the Wayland thread (which I'll fix soon), but otherwise everything gets reported properly by the compositor even in between focus changes (rightly so, as there's no pointer query API on WL), so we're mostly set :D

@bruvzg
Copy link
Member Author

bruvzg commented May 30, 2024

I think that the freelook fix bundled is more of a workaround

It is, and it's not related to mouse button state. Freelook can be activated by keyboard as well, and it's only checking its internal state after it is activated (or release event is received), releasing it on focus out as well seems to be reasonable thing to do.

@akien-mga
Copy link
Member

Needs rebase.

@akien-mga akien-mga merged commit e716ea6 into godotengine:master Jun 3, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants