-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use current mouse button state instead of saved values. #92424
Conversation
627784b
to
ed1d157
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave a look, things look fine!
I think that the freelook fix bundled is more of a workaround (see #92455 (comment) ) but it will do for now.
I also researched a bit on the Wayland side and things aren't bad at all. There's a bit of a focus tracking bug in the Wayland thread (which I'll fix soon), but otherwise everything gets reported properly by the compositor even in between focus changes (rightly so, as there's no pointer query API on WL), so we're mostly set :D
It is, and it's not related to mouse button state. Freelook can be activated by keyboard as well, and it's only checking its internal state after it is activated (or release event is received), releasing it on focus out as well seems to be reasonable thing to do. |
Needs rebase. |
Thanks! |
Same as #92415, but for mouse buttons.