-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android: Remove the limit on the number of the SignalInfo creation function parameters #92580
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic looks good to me.
Could you squash the commits? See [PR workflow](https://docs.godotengine.org/en/latest/contributing/workflow/ Note also that your first commit's git details don't seem to match your GitHub account, but this was fixed for the second commit. If you want to use that second identity for the squashed commit, you can do |
Update platform/android/api/jni_singleton.h Co-authored-by: A Thousand Ships (she/her) <[email protected]>
@akien-mga Done~ |
Thanks! And congrats for your first merged Godot contribution 🎉 |
Guys, check this #92507