Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Remove the limit on the number of the SignalInfo creation function parameters #92580

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

hccloud
Copy link
Contributor

@hccloud hccloud commented May 31, 2024

Guys, check this #92507

@hccloud hccloud requested a review from a team as a code owner May 31, 2024 06:08
@hccloud hccloud changed the title Remove the limit on the number of the SignalInfo function parameters Remove the limit on the number of the SignalInfo creation function parameters May 31, 2024
@YeldhamDev YeldhamDev added this to the 4.x milestone May 31, 2024
Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks good to me.

@akien-mga
Copy link
Member

Could you squash the commits? See [PR workflow](https://docs.godotengine.org/en/latest/contributing/workflow/
pr_workflow.html#the-interactive-rebase) for instructions.

Note also that your first commit's git details don't seem to match your GitHub account, but this was fixed for the second commit. If you want to use that second identity for the squashed commit, you can do git commit --amend --reset-author after squashing.

Update platform/android/api/jni_singleton.h

Co-authored-by: A Thousand Ships (she/her) <[email protected]>
@hccloud
Copy link
Contributor Author

hccloud commented Jun 5, 2024

Could you squash the commits? See [PR workflow](https://docs.godotengine.org/en/latest/contributing/workflow/ pr_workflow.html#the-interactive-rebase) for instructions.

Note also that your first commit's git details don't seem to match your GitHub account, but this was fixed for the second commit. If you want to use that second identity for the squashed commit, you can do git commit --amend --reset-author after squashing.

@akien-mga Done~

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Jun 5, 2024
@akien-mga akien-mga merged commit 0b24f40 into godotengine:master Jun 7, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@akien-mga akien-mga changed the title Remove the limit on the number of the SignalInfo creation function parameters Android: Remove the limit on the number of the SignalInfo creation function parameters Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants