Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iOS exports never embedding framework bundles #92692

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

mihe
Copy link
Contributor

@mihe mihe commented Jun 2, 2024

This partially reverts #86288.

Currently when exporting projects for iOS that (for example) rely on a GDExtension which is built as a .framework bundle, you will find that while said .framework bundle is exported along with the Xcode project, it doesn't actually get embedded into the app bundle when building/archiving, which breaks the application.

This seems to be because the iOS export plugin currently treats .framework the same as .xcframework, where it expects there to be an AvailableLibraries key in the bundle Info.plist, which doesn't seem to be a thing for regular .framework bundles.

This PR fixes this issue by going back to the behavior prior to #86288 for .framework bundles specifically, where IOSExportAsset::should_embed is always respected.

@mihe mihe requested a review from a team as a code owner June 2, 2024 16:02
@Calinou Calinou added this to the 4.3 milestone Jun 2, 2024
@akien-mga akien-mga merged commit f976a62 into godotengine:master Jun 3, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@mihe mihe deleted the always-embed-frameworks branch June 3, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants