Fix iOS exports never embedding framework bundles #92692
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially reverts #86288.
Currently when exporting projects for iOS that (for example) rely on a GDExtension which is built as a
.framework
bundle, you will find that while said.framework
bundle is exported along with the Xcode project, it doesn't actually get embedded into the app bundle when building/archiving, which breaks the application.This seems to be because the iOS export plugin currently treats
.framework
the same as.xcframework
, where it expects there to be anAvailableLibraries
key in the bundleInfo.plist
, which doesn't seem to be a thing for regular.framework
bundles.This PR fixes this issue by going back to the behavior prior to #86288 for
.framework
bundles specifically, whereIOSExportAsset::should_embed
is always respected.