Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TextServer, GDExtension] Fix building text servers as GDExtension, expose new/changed low-level methods to GDExtension API. #92715

Merged
merged 1 commit into from
Jun 13, 2024
Merged

[TextServer, GDExtension] Fix building text servers as GDExtension, expose new/changed low-level methods to GDExtension API. #92715

merged 1 commit into from
Jun 13, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jun 3, 2024 •
edited
Loading

Restores ability to build text serves as GDExtension:

  • Exposes modified String and Image low-level access methods to GDExtension.
  • Exposes some previously private methods to the scripting.
  • Fixes various inconsistencies in the text server API.
  • Fixes outdated GDExtension build configs.

godot-cpp counterpart - godotengine/godot-cpp#1479

@bruvzg bruvzg added this to the 4.x milestone Jun 3, 2024
@bruvzg bruvzg mentioned this pull request Jun 3, 2024
Merged
@dsnopek
Copy link
Contributor

dsnopek commented Jun 10, 2024

The changes here look good to me! What else is needed to take this out of draft?

@bruvzg bruvzg marked this pull request as ready for review June 11, 2024 06:48
@bruvzg bruvzg requested review from a team as code owners June 11, 2024 06:48
dsnopek
dsnopek approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I only have the one note about adding @deprecated to the old functions in gdextension_interface.h

core/extension/gdextension_interface.h Show resolved Hide resolved
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Jun 11, 2024
@bruvzg
[TextServer, GDExtension] Fix building text servers as GDExtension, e…
e651421 
…xpose new/changed low-level methods to GDExtension API.
@akien-mga akien-mga merged commit 68ebce2 into godotengine:master Jun 13, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsnopek dsnopek dsnopek approved these changes

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
bug topic:gdextension topic:gui
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@bruvzg @dsnopek @akien-mga @AThousandShips