Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix callable not clearing freed pointer #92722

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

rune-scape
Copy link
Contributor

fixes a crash i had on shutdown,,
but it happens anytime a callable with a custom pointer is copy-assigned a regular callable, then destructed
manual reference counting and memory managment should rlly be abstracted or avoided to prevent silly crashes like this

@rune-scape rune-scape requested a review from a team as a code owner June 3, 2024 11:30
@AThousandShips AThousandShips added bug topic:core cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Jun 3, 2024
@AThousandShips AThousandShips added this to the 4.3 milestone Jun 3, 2024
@fire fire changed the title fix callable not clearing freed pointer Fix callable not clearing freed pointer Jun 3, 2024
@akien-mga akien-mga merged commit 7b63ac4 into godotengine:master Jun 4, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@rune-scape rune-scape deleted the fix-callable-crash branch June 5, 2024 01:21
@DanielSnd
Copy link
Contributor

I've had an annoying crash when closing my games on mac forever, after this merge it's gone, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release topic:core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants