-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Adreno 3xx compatibility for devices with newer driver versions #92741
Fix Adreno 3xx compatibility for devices with newer driver versions #92741
Conversation
e53ace8
to
12c981c
Compare
Co-Authored-By: Hugo Locurcio <[email protected]> Co-Authored-By: Clay John <[email protected]>
12c981c
to
aed6b02
Compare
I could not reproduce a crash when Tests on Firebase Test LabMoto Z, Android API 24, Adreno (TM) 530, GLES 3.2 [email protected] web-build_20240613_7bwb_griffin-24-en_US-landscape_video.mp4moto e5 play, Android API 27, Adreno (TM) 308, GLES 3.0 [email protected] web-build_20240613_7bwb_pettyl-27-en_US-landscape_video.mp4Note: on Adreno 5xx with Vulkan Mobile the GPUParticles does not work either, invisible. ( https://docs.godotengine.org/en/stable/tutorials/shaders/compute_shaders.html
|
Looking back at #88816 I am reminded that joined72 was able to fix the crash, but the particles still do not show up. In the end, we decided to disable them because they were invisible anyway and they reduced performance a lot #88816 (comment). Accordingly, I would keep the disable_particles_workaround for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. We still don't know exactly what driver version the flip_xy bug was fixed in, but the code looks great. We can adjust the exact driver version in the check once we have confirmation from Qualcomm
Thanks! |
Fixes #92662
Adreno 3xx
devices with newer driver version are not affected.