Add SVG pre-commit check to avoid broken colors when using style tags #92744
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a pygrep-based check to pre-commit that checks if any
fill
,stroke
andstop-color
properties are being set inside style tags in SVG, this prevents introducing icons that will have broken colors in light modes.I've ran into this issue twice before in #92504 and #91821, because
ImageLoaderSVG
does a search & replace on the attribute values but not the style tags, and rather than complicate that code it's probably simpler to just avoid committing SVG it doesn't like in the first place.