Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: Escape generated members #93198

Merged
merged 1 commit into from
Jun 20, 2024
Merged

C#: Escape generated members #93198

merged 1 commit into from
Jun 20, 2024

Conversation

raulsntos
Copy link
Member

@raulsntos raulsntos added bug topic:dotnet cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Jun 15, 2024
@raulsntos raulsntos added this to the 4.3 milestone Jun 15, 2024
@raulsntos raulsntos requested a review from a team as a code owner June 15, 2024 17:03
@raulsntos raulsntos force-pushed the dotnet/escape-generated-members branch from 63e8d64 to 65cd0c8 Compare June 15, 2024 17:07
@raulsntos raulsntos requested a review from a team as a code owner June 15, 2024 17:07
paulloz
paulloz approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@paulloz paulloz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. But I haven't had that much time to test.

@akien-mga akien-mga merged commit 24ce308 into godotengine:master Jun 20, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@raulsntos raulsntos deleted the dotnet/escape-generated-members branch June 21, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulloz paulloz paulloz approved these changes

Assignees
No one assigned
Labels
bug cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release topic:dotnet
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Naming a C# field @new cause Godot to generate invalid C# code
3 participants
@raulsntos @akien-mga @paulloz