Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix symbol lookup for native enums #93566

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Jun 24, 2024

Before:

enum_fix_before

After:

enum_fix_after

Also fixes integer constant symbol lookup (currently it targets to an enum name rather than a constant inside that enum):

constant_fix

@Chaosus Chaosus requested a review from a team as a code owner June 24, 2024 18:59
@Chaosus Chaosus added this to the 4.3 milestone Jun 24, 2024
@Chaosus Chaosus force-pushed the gds_fix_enum_lookup branch 2 times, most recently from da2a0ec to c4718bb Compare June 24, 2024 20:26
@akien-mga akien-mga merged commit 93fc9b8 into godotengine:master Jun 26, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Chaosus Chaosus deleted the gds_fix_enum_lookup branch June 26, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants