Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code for setup of global_func_set in ShaderLanguage #93866

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Jul 2, 2024

That how #93849 should be, I hurried

@Chaosus Chaosus requested a review from a team as a code owner July 2, 2024 15:19
@Chaosus Chaosus added this to the 4.3 milestone Jul 2, 2024
@akien-mga
Copy link
Member

I wonder about thread safety, is that fine? CC @RandomShaper

I assumed ShaderLanguage didn't have multiple instances, but I guess it does?

@Chaosus
Copy link
Member Author

Chaosus commented Jul 2, 2024

@akien-mga There are multiple shader compilers one for each type of shader, each of them contain its own ShaderLanguage instance - so it's more logically to add some kind of code safety, at least to not repeat the same process of filling the same array... dunno about the aspect of multithreading

@akien-mga akien-mga merged commit 40cb283 into godotengine:master Jul 9, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@Chaosus Chaosus deleted the shader_fix_global_func_set branch July 9, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants