-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix preloading a zip in the web editor #93906
Fix preloading a zip in the web editor #93906
Conversation
b44b0d2
to
8b3dd85
Compare
Amended the commit message to be clearer than "fix" (and squash the commits). Please keep in mind to write clear commit messages for future PRs, see https://github.com/godotengine/godot/blob/master/CONTRIBUTING.md#format-your-commit-messages-with-readability-in-mind |
8b3dd85
to
db97d88
Compare
Thanks! And congrats for your first merged Godot contribution 🎉 |
Seems like I introduced a bug when rebasing, I changed the include from
|
My bad, I introduced the bug when amending it.
Fixed up with ce16818. We should look into actually including |
My bad, I introduced the bug when amending it.
My bad, I introduced the bug when amending it.
My bad, I introduced the bug when amending it.
My bad, I introduced the bug when amending it.
When the versions went from 3 to 4 the
MainLoop
no longer responds to thefiles_dropped
signal. This change sends thefiles_dropped
signal to the root window and causes it to open the import dialog box.