Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for Animation.track_set_path and AnimationMixer.root_motion_track #94007

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

scotmcp
Copy link
Contributor

@scotmcp scotmcp commented Jul 6, 2024

Updated the usage description of [method Animation.track_set_path] and [member Animation.root_motion_track] to identify the parent is the root_node identified in animation player, and that the format is the same for each.

@scotmcp scotmcp requested a review from a team as a code owner July 6, 2024 20:12
@Calinou Calinou added enhancement documentation cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release and removed cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Jul 6, 2024
@Calinou Calinou added this to the 4.3 milestone Jul 6, 2024
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make your changes with git commit --amend

doc/classes/AnimationMixer.xml Outdated Show resolved Hide resolved
Updated the usage description of [method Animation.track_set_path] and [member Animation.root_motion_track] to identify the parent is the root_node identified in animation player, and that the format is the same for each.

Remove extra symbols
@akien-mga akien-mga changed the title Update Animation.track_set_path and AnimationMixer.root_motion_track Update docs for Animation.track_set_path and AnimationMixer.root_motion_track Jul 7, 2024
@akien-mga akien-mga merged commit 73b6544 into godotengine:master Jul 7, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release documentation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants